[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make telemetryService defined #2980

Open
1 task
Tracked by #2979
mkurapov opened this issue Sep 17, 2024 · 0 comments · May be fixed by #2991
Open
1 task
Tracked by #2979

Make telemetryService defined #2980

mkurapov opened this issue Sep 17, 2024 · 0 comments · May be fixed by #2991
Assignees

Comments

@mkurapov
Copy link
Contributor
mkurapov commented Sep 17, 2024

Context

We have a lot of cases in the backend code where we are checking whether telemetry service is defined or not. However, we should assume that each of the services in the containers are always defined.

In order to still respect the ENABLE_TELEMETRY and ENABLE_TELEMETRY_TRACES flags, all we can do is just to not register metric/trace providers in the telemetry initialization.

Todo

  • Make telemetryService required, update dependents
@mkurapov mkurapov changed the title Make telemetryService required Make telemetry required Sep 17, 2024
@mkurapov mkurapov changed the title Make telemetry required Make telemetryService defined Sep 17, 2024
@BlairCurrey BlairCurrey self-assigned this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for Review
Development

Successfully merging a pull request may close this issue.

2 participants