[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiny optimisations of dag.Set #28329

Merged
merged 1 commit into from
Apr 14, 2021
Merged

tiny optimisations of dag.Set #28329

merged 1 commit into from
Apr 14, 2021

Conversation

serejkus
Copy link
Contributor
@serejkus serejkus commented Apr 9, 2021
  1. Use hint for map size in Set.Copy().
  2. Use Set.Copy() if Set.Difference() argument is empty.

@serejkus
tiny optimisations of dag.Set
1ad01de 
1. Use hint for map size in Set.Copy().
2. Use Set.Copy() if Set.Difference() argument is empty.
@hashicorp-cla
Copy link
hashicorp-cla commented Apr 9, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link
codecov bot commented Apr 9, 2021

Codecov Report

Merging #28329 (1ad01de) into main (1212bbe) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
dag/set.go 85.29% <100.00%> (-0.43%) ⬇️
states/statefile/version4.go 58.19% <0.00%> (+0.23%) ⬆️
terraform/node_resource_plan.go 98.05% <0.00%> (+1.94%) ⬆️
internal/providercache/dir.go 73.46% <0.00%> (+6.12%) ⬆️

@jbardin jbardin self-assigned this Apr 12, 2021
@jbardin jbardin added the 0.15-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Apr 14, 2021
@jbardin
Copy link
Member
jbardin commented Apr 14, 2021

Thanks @serejkus!

@jbardin jbardin merged commit 2cd1619 into hashicorp:main Apr 14, 2021
@teamterraform teamterraform mentioned this pull request Apr 14, 2021
Merged
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jbardin jbardin

Labels
0.15-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serejkus @hashicorp-cla @jbardin