-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HHVM Extension Support #11553
HHVM Extension Support #11553
Conversation
Adding in potential fix for segfault in plugin_get_metadata due to HP…
@RyanGordon Thanks for keep improve this PR. Please let me know once it's ready for another round review. |
@fengli79 Thanks! I will do; I expect this will be ready for review in about a week. I may also close and re-open this as a new PR and squash the commits down so the PR is cleaner |
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
change . to -> for oset
Hi. I am testing it with protobuf hhvm, but it seems the installation instruction in README file is out of date. Can you please update it introduce how to install it and what the dependencies are. |
This adds support for running gRPC with HHVM as a native extension. This ports over all of the methods and code from the PHP extension with the same interface. This is apart of getting Cloud Spanner to run on HHVM using the official PHP library which requires gRPC.
This still is a WIP, and not ready for production.