[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHVM Extension Support #11553

Closed
wants to merge 253 commits into from
Closed

HHVM Extension Support #11553

wants to merge 253 commits into from

Conversation

RyanGordon
Copy link

This adds support for running gRPC with HHVM as a native extension. This ports over all of the methods and code from the PHP extension with the same interface. This is apart of getting Cloud Spanner to run on HHVM using the official PHP library which requires gRPC.

This still is a WIP, and not ready for production.

@fengli79
Copy link
Contributor

@RyanGordon Thanks for keep improve this PR. Please let me know once it's ready for another round review.

@RyanGordon
Copy link
Author

@fengli79 Thanks! I will do; I expect this will be ready for review in about a week. I may also close and re-open this as a new PR and squash the commits down so the PR is cleaner

@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
The Linux Foundation CLA GitHub bot

@ZhouyihaiDing
Copy link
Contributor
ZhouyihaiDing commented Mar 29, 2018

Hi. I am testing it with protobuf hhvm, but it seems the installation instruction in README file is out of date. Can you please update it introduce how to install it and what the dependencies are.
I installed a lot of things like boost, folly, and have This file requires compiler and library support for the forthcoming ISO C++ 2014 standard. issue during the installation. Can you please introduce where to add --std=gnu++1y. CMAKE_CXX_FLAGS="--std=gnu++1y" cmake . doesn't work.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.