[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: feature: "move declaration" refactoring #70583

Open
adonovan opened this issue Nov 26, 2024 · 1 comment
Open

x/tools/gopls: feature: "move declaration" refactoring #70583

adonovan opened this issue Nov 26, 2024 · 1 comment
Labels
gopls Issues related to the Go language server, gopls. Refactoring Issues related to refactoring tools Tools This label describes issues relating to any tools in the x/tools repository.

Comments

@adonovan
Copy link
Member
adonovan commented Nov 26, 2024

A generalization of renaming a symbol X to Y is to rename X to otherpkg.Y, causing the declaration of X, along with any necessary supporting declarations, to be moved into some file in the designated other package. There are a fair number of edge cases to consider, and UI questions such as how best to obtain the name of otherpkg: the only current LSP operation that supports dialog is Rename, which rather forces our hand. (Another possibility is to use the web interface, which could give a rich interactive menu of which declarations should be moved and optionally renamed at the same time.)

@adonovan adonovan added Tools This label describes issues relating to any tools in the x/tools repository. Refactoring Issues related to refactoring tools gopls Issues related to the Go language server, gopls. labels Nov 26, 2024
@gopherbot gopherbot added this to the Unreleased milestone Nov 26, 2024
@gabyhelp
Copy link

Related Issues

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@adonovan adonovan modified the milestones: Unreleased, gopls, Backlog Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. Refactoring Issues related to refactoring tools Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants