Allow to select multiple remote nodes at runtime #99680
Draft
+1,382
−292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YeldhamDev
commented
Nov 25, 2024
scene/debugger/scene_debugger.cpp
Outdated
Comment on lines
140
to
149
| } else if (p_msg == "inspect_multi_objects") { | ||
| ERR_FAIL_COND_V(p_args.is_empty(), ERR_INVALID_DATA); | ||
| Vector<ObjectID> ids; | ||
| for (const ObjectID id : p_args) { | ||
| ids.append(id); | ||
| } | ||
| // Sorting is necessary to avoid the values constantly changing in the inspector. | ||
| // The downside is that it's ordered by index instead of selection order. | ||
| ids.sort(); | ||
| _send_multi_object_ids(ids); |
There was a problem hiding this comment.
I would like some feedback here: currently, if multiple object inspection is desired, the "inspect_multi_objects" message (which takes an array of ids) should be used.
Should this stay as a separate message, or be removed in favor of "inspect_object" always taking an array?
f74dd90
to
c158225
Compare
c158225
to
c618297
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #93628.
Screencast_20241125_111648.webm
Features Implemented
MultiNodeEditworks.Node2D/Controlnodes.Things Missing
Sponsored By: 🐺 Lone Wolf Technology / 🍀 W4 Games.