Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard information about the request
This is a: bug fix, new feature, efficiency update, other (please describe)
This change affects: inference
This change changes: the
nessai
sampler to support the importance nested sampler versionThis change: is tested via an example, follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines
This change will: does not break any existing code
Motivation
With the release of nessai 0.12.0, a method for mapping from the prior to the unit hypercube is no longer required for the importance nested sampler (ins). This means we can support the ins (inessai) with a few minor changes to the existing implementation.
Contents
Updates to the existing class so that it supports the
importance_nested_sampler
option. This isFalse
by default.I also added a second class
INessaiSampler
that has this default switch toTrue
and has the name set toinessai
.This means there are two ways of calling the importance nested sampler.
Testing performed
Run the example included in
examples/inference/samplers/
Additional notes
To-do
Test checkpoint after this change, since it reworks the
samples
property.Test on BBH
The author of this pull request confirms they will adhere to the code of conduct