-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panic on windows #19
Comments
If Windows supports hardlinks, perhaps switching everything to hardlinks would make sense. Any drawbacks you can think of? I'll go ahead and setup a GHA runner with Windows… |
Well, I am not very deep in the matter, but as long as files end up on the same drive (partition), hardlinks are not an issue afaik. Not sure if we can make sure that this is a given. It's possible we need to reconsider where to save the temporary data. If I remember correctly, it uses the systems / users temp folder? According to the underlying docs of So, what we could do, is to create a local |
I tested the hardlinks and it seems to work just fine on windows. I also can't think of any risks. The only difference would be, that keeping the tempfiles would keep the real files accessible, as hardlinked data is kept until the last hardlink has been deleted. This isn't necessarily be a problem, but just something to be aware of. |
Calls to
os.Symlink
can error on windows, due to lack of "certain permissions". Can we just replace this with hardlinking? If so, only for Windows, or for all systems?The text was updated successfully, but these errors were encountered: