[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console panel overlaps with the Preview panel #57028

Open
mmatsumoto1026 opened this issue Nov 2, 2024 · 4 comments · May be fixed by #57044
Open

Console panel overlaps with the Preview panel #57028

mmatsumoto1026 opened this issue Nov 2, 2024 · 4 comments · May be fixed by #57044
Labels
help wanted Open for all. You do not need permission to work on these. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: UI Threads for addressing UX changes and improvements to user interface

Comments

@mmatsumoto1026
Copy link
Contributor
mmatsumoto1026 commented Nov 2, 2024

Describe the Issue

With the desktop layout on Step based challenge, When the console panel is opened, it overlaps with the preview panel, making part of the preview invisible unless the camper reduces the height of console panel.
Therefore, the camper cannot open a large enough console panel to debug and see all of the preview panel at the same time.
(It seems that the min-height: 70vh; property for .challenge-preview class is the cause of this issue.)

Affected Page

https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-basic-string-and-array-methods-by-building-a-music-player/step-76

Steps to Reproduce

  1. Go to https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-basic-string-and-array-methods-by-building-a-music-player/step-76 with desktop layout
  2. Click on "Console" panel open button
  3. See the overlapping

Expected behavior

The console panel does not overlap with the preview panel, so campers can always refer the entire preview panel even when they have the console panel open with enough height.

Screenshots

Console panel overlaps with the Preview panel

System

  • Device: Laptop
  • OS: Windows 11
  • Browser: Chrome, Firefox, Edge, Brave
  • Version: 130.0.6723.92 (Official Build) (64-bit) - Chrome

Additional context

None

@mmatsumoto1026 mmatsumoto1026 added the status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. label Nov 2, 2024
@gikf gikf added scope: UI Threads for addressing UX changes and improvements to user interface platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. labels Nov 2, 2024
@jatin0801
Copy link

Taking this one on!

@ilenia-magoni
Copy link
Contributor

@jatin0801 this issue is not open for contributing, it has not been triaged yet

@lasjorg
Copy link
Contributor
lasjorg commented Nov 4, 2024

Not sure why we need the min-height all it seems to do is create the non-scrollable overflow.

Unless I'm missing something, I would suggest removing it.


We do have the same issue with the Python challenges output console, but that is less of an issue and isn't fixed by removing the referred to min-height.

@naomi-lgbt
Copy link
Member

That should be fine to remove, I think. Opening for contribution.

@naomi-lgbt naomi-lgbt added help wanted Open for all. You do not need permission to work on these. and removed status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. labels Nov 4, 2024
@sam-shubham sam-shubham linked a pull request Nov 4, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open for all. You do not need permission to work on these. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: UI Threads for addressing UX changes and improvements to user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants