[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help Wanted #3742

Open
emilk opened this issue Dec 28, 2023 · 2 comments
Open

Help Wanted #3742

emilk opened this issue Dec 28, 2023 · 2 comments

Comments

@emilk
Copy link
Owner
emilk commented Dec 28, 2023 •
edited
Loading

Are you looking to help out on the egui project? Then this is a good place to start!

There are a few things you can help out with:

First, make sure you read CONTRIBUTING.md.

Contributing code

You can browse existing issues. A lot of them are unfortunately uncategorized, but I've tried adding "good first issue" and "help wanted" on some of them, but of course, I actually want help with all of them 😆

I use Mac for all my work, so sometimes the Linux and Windows integrations for eframe suffer. Therefore I would appreciate help with that!

If you are good at web programming, there are plenty of issues related to the eframe web integration.

There is a milestone with issues that should be fixed before the next release - any help with these issues would be most welcome! https://github.com/emilk/egui/milestone/3

Some cherry-picked issues in no particular order:

Maintain egui_plot
@emilk emilk pinned this issue Dec 28, 2023
@samitbasu
Copy link
Contributor

Hi @emilk - thanks for making UI's fun again! On the PR reviews, a couple of questions:

  • Can anyone review PRs? Or do they need to belong to the project somehow?
  • What happens with PRs that contain API breaking changes (e.g., something that would cause egui_extras to break its API for example.

Also, would it help you if more functionality was broken out of the egui repo (like egui_plot)? Would that allowed for a more distributed support model?

@emilk
Copy link
Owner Author
emilk commented Dec 29, 2023 •
edited
Loading

Great questions!

Anyone is welcome to help review PRs, in order to provide feedback and help the PR author. Of course, someone with merge rights will still have the final say (most likely me), but the more eyes on a PR, the better it usually ends up!

Breaking changes are usually fine, but should be documented in the PR description. Of course, if they can be avoided without creating to much hassle, that's often better. Also, using #[deprecated] on removed stuff is encouraged.

Breaking out crates from the monorepo would be nice, but I like having egui and eframe in the same mono-repo, as it makes for much easier testing and iteration.

egui_plot should probably be moved to its own repository though. If anyone would like to take the lead on that I'd be very happy. I'd rather not be the maintainer of egui_plot (I've only written a very small fraction of it).

EDIT: egui_plot has been moved to https://github.com/emilk/egui_plot/

@dbuch dbuch mentioned this issue Dec 30, 2023
Merged
Repository owner deleted a comment from nabby27 Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emilk @samitbasu