[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eyedropper of color picker can't pick color outside of window #27980

Open
3 tasks done
kutu opened this issue Mar 3, 2021 · 30 comments
Open
3 tasks done

Eyedropper of color picker can't pick color outside of window #27980

kutu opened this issue Mar 3, 2021 · 30 comments

Comments

@kutu
Copy link
kutu commented Mar 3, 2021

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • 12.0.0
  • Operating System:
    • Windows 10 (1909)
  • Last Known Working Electron version:
    • no such

Expected Behavior

Be able to eyedrop color from outside of electron window

Actual Behavior

Eyedrop magnifier disappears outside of electron window

To Reproduce

electron fiddle
https://gist.github.com/kutu/cca8df7c89d317d298213c8a0ce32da5

Screenshots

image

Additional Information

In screenshot, you can see that eyedropper see pixels outside of the electron window, but you can't eyedrop them, and eyedrop magnifier crops at the edge of electron window.

@nornagon
Copy link
Member
nornagon commented Mar 3, 2021

I can reproduce on Windows, but not on macOS. In Chrome, the picker seems to be able to exceed the window bounds, so this does seem Electron-specific.

@kutu
Copy link
Author
kutu commented Jun 9, 2021

same issue on versions 13.x and 14.beta, Windows 10 64bit version 2004

@JannisX11
Copy link

The same issue occurs with the new EyeDropper API introduced in Chromium 95 (tested in Electron 16.0.0-beta.9).

@unclehking
Copy link

The same issue occurs with the new EyeDropper API introduced in

Electron 16.0.0-beta.9

Node 16.9.1

Chromium 96.0.4664.35

@dr-js
Copy link
dr-js commented Dec 24, 2021

Currently the following version all limit the Eyedrop magnifier circle rendering inside of the browser window: (Win10 21H2 19044 x64)

  • electron-v16.0.5-win32-x64
  • electron-v17.0.0-alpha.5-win32-x64
  • electron-v18.0.0-nightly.20211223-win32-x64

Test by drag & drop the test script file onto each electron.exe:

// quick-test.js
(async () => {
  const { app, BrowserWindow } = require('electron')
  await app.whenReady()
  new BrowserWindow({  width: 800,  height: 600})
    .loadURL('https://developer.mozilla.org/en-US/docs/Web/API/EyeDropper#result') // use MDN sample to test
})()

Then use the MDN sample to test

On same system Chrome 96.0.4664.110 and nwjs-sdk-v0.59.0-win-x64 all open & pick outside window area as expected.

The problem seems to be related to the Eyedrop magnifier circle not keep rendering & following the mouse pointer to catch & consume the next click.
If the clicking outside is at the taskbar & cause the Electron window to minimize, the color picking is not stopped and the mouse pointer will not show inside the restored Electron window, clicking at the Electron window titlebar seems to end the color picking process and fix the pointer rendering.

@dr-js
Copy link
dr-js commented Mar 25, 2022

Update: the following version still limit the Eyedrop magnifier circle rendering inside of the browser window: (Win10 21H2 19044.1586 x64)

  • electron-v17.2.0-win32-x64
  • electron-v18.0.0-beta.6-win32-x64
  • electron-v19.0.0-nightly.20220324-win32-x64

@dr-js
Copy link
dr-js commented May 27, 2022

Update: the following version still limit the Eyedrop magnifier circle, now with red-colored grid lines in Win11 dark mode (Win11 21H2 22000.708 x64)

  • electron-v20.0.0-alpha.1-win32-x64
  • electron-v19.0.1-win32-x64

image

@github-actions
Copy link
Contributor
github-actions bot commented Oct 6, 2022

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Oct 6, 2022
@JoaoTMDias
Copy link

Bump

@github-actions github-actions bot removed the stale label Oct 7, 2022
@Penggeor

This comment was marked as off-topic.

@Imperat
Copy link
Contributor
Imperat commented Dec 23, 2022

+1 here.

On Windows 11 and Electron v 20.1.4 it does not allow me to pick colours outside of window boundaries
https://gist.github.com/d83fd232d331c5c2bcbaf6fd26a7f15f
However, the web example works well in Chrome: https://captainbrosset.github.io/eyedropper-demos/color-game.html

@dr-js
Copy link
dr-js commented Dec 26, 2022

Update: the following version still limit the Eyedrop magnifier circle (Win11 22H2 22621.963 x64)

  • electron-v24.0.0-nightly.20221216-win32-x64
  • electron-v22.0.0-win32-x64

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Mar 27, 2023
@dr-js
Copy link
dr-js commented Mar 30, 2023

Update: the following version still limit the Eyedrop magnifier circle (Win11 22H2 22621.1413 x64)

  • electron-v25.0.0-nightly.20230329-win32-x64
  • electron-v24.0.0-beta.6-win32-x64
  • electron-v23.2.1-win32-x64

@github-actions github-actions bot removed the stale label Mar 31, 2023
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Jun 29, 2023
@Imperat
Copy link
Contributor
Imperat commented Sep 30, 2023

Bump

@electron-issue-triage
Copy link

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@Imperat
Copy link
Contributor
Imperat commented Dec 31, 2023

Bump please

@dr-js
Copy link
dr-js commented Mar 1, 2024

Update: recent version still limit the Eyedrop magnifier circle (Win10 22H2 19045.4046 x64)

  • electron-v30.0.0-alpha.3-win32-x64

image

@electron-issue-triage
Copy link

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@Penggeor
Copy link

bump

@electron-issue-triage
Copy link

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@JannisX11
Copy link

Reproduced in electron 32.0.1 and 33.0.0-alpha.1.

@github-project-automation github-project-automation bot moved this to 👀 Unsorted Items in 33-x-y Sep 12, 2024
@github-project-automation github-project-automation bot moved this to 👀 Unsorted Items in 32-x-y Sep 12, 2024
@mlaurencin
Copy link
Member

Closed by #43685

@JannisX11
Copy link

Closed by #43685

This issue was not fixed. The linked PR fixes a different issue. Please reopen.

The issue can still be reproduced in the latest beta 33.0.0-beta.3 and in 32.1.2.

@mlaurencin mlaurencin reopened this Oct 1, 2024
@mlaurencin mlaurencin moved this from 🛠️ Fixed for Next Release to 👀 Unsorted Items in 32-x-y Oct 1, 2024
@mlaurencin mlaurencin moved this from 🛠️ Fixed for Next Release to 👀 Unsorted Items in 33-x-y Oct 1, 2024
@mlaurencin mlaurencin moved this from 👀 Unsorted Items to 👍 Does Not Block Stable in 32-x-y Oct 2, 2024
@mlaurencin mlaurencin moved this from 👀 Unsorted Items to 👍 Does Not Block Stable in 33-x-y Oct 2, 2024
@angela0202
Copy link

Is there an update on the fix? Any idea when it might be ready?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👍 Does Not Block Stable
Status: 👍 Does Not Block Stable
Development

No branches or pull requests