-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eyedropper of color picker can't pick color outside of window #27980
Comments
I can reproduce on Windows, but not on macOS. In Chrome, the picker seems to be able to exceed the window bounds, so this does seem Electron-specific. |
same issue on versions 13.x and 14.beta, Windows 10 64bit version 2004 |
The same issue occurs with the new EyeDropper API introduced in Chromium 95 (tested in Electron 16.0.0-beta.9). |
The same issue occurs with the new EyeDropper API introduced in Electron 16.0.0-beta.9Node 16.9.1Chromium 96.0.4664.35 |
Currently the following version all limit the Eyedrop magnifier circle rendering inside of the browser window: (Win10 21H2 19044 x64)
Test by drag & drop the test script file onto each // quick-test.js
(async () => {
const { app, BrowserWindow } = require('electron')
await app.whenReady()
new BrowserWindow({ width: 800, height: 600})
.loadURL('https://developer.mozilla.org/en-US/docs/Web/API/EyeDropper#result') // use MDN sample to test
})() Then use the MDN sample to test On same system The problem seems to be related to the Eyedrop magnifier circle not keep rendering & following the mouse pointer to catch & consume the next click. |
Update: the following version still limit the Eyedrop magnifier circle rendering inside of the browser window: (Win10 21H2 19044.1586 x64)
|
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment! |
Bump |
This comment was marked as off-topic.
This comment was marked as off-topic.
+1 here. On Windows 11 and Electron v 20.1.4 it does not allow me to pick colours outside of window boundaries |
Update: the following version still limit the Eyedrop magnifier circle (Win11 22H2 22621.963 x64)
|
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment! |
Update: the following version still limit the Eyedrop magnifier circle (Win11 22H2 22621.1413 x64)
|
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment! |
Bump |
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment! |
Bump please |
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment! |
bump |
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment! |
Reproduced in electron 32.0.1 and 33.0.0-alpha.1. |
Closed by #43685 |
This issue was not fixed. The linked PR fixes a different issue. Please reopen. The issue can still be reproduced in the latest beta |
Is there an update on the fix? Any idea when it might be ready? |
Preflight Checklist
Issue Details
Expected Behavior
Be able to eyedrop color from outside of electron window
Actual Behavior
Eyedrop magnifier disappears outside of electron window
To Reproduce
electron fiddle
https://gist.github.com/kutu/cca8df7c89d317d298213c8a0ce32da5
Screenshots
Additional Information
In screenshot, you can see that eyedropper see pixels outside of the electron window, but you can't eyedrop them, and eyedrop magnifier crops at the edge of electron window.
The text was updated successfully, but these errors were encountered: