[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UBSAN][DQM] shift exponent too large for 32-bit type int #46483

Open
smuzaffar opened this issue Oct 22, 2024 · 4 comments
Open

[UBSAN][DQM] shift exponent too large for 32-bit type int #46483

smuzaffar opened this issue Oct 22, 2024 · 4 comments
Labels
dqm-pending pending-signatures

Comments

@smuzaffar
Copy link
Contributor

There are few UBSAN errors about shift exponent too large for 32-bit type int [a]. Normally this indicates that there might be some logical error. @cms-sw/dqm-l2 , can you please check the code and see if we can avoid this errors.

One way to fix/avoid these errors is to use 1 << (variable&0x1F) instead of 1 << variable but I am not sure how portable this code will be.

[a] https://cmssdt.cern.ch/SDT/jenkins-artifacts/ubsan_logs/CMSSW_14_2_X_2024-10-20-2300/
27 DQM/GEM/plugins/GEMDAQStatusSource.cc:487:28: runtime error: shift exponent 32 is too large for 32-bit type 'int'
27 DQM/GEM/plugins/GEMDAQStatusSource.cc:559:58: runtime error: shift exponent 39 is too large for 32-bit type 'int'
27 [DQM/GEM/plugins/GEMDAQStatusSource.cc:560](https://github.com/cms-sw/cmssw/blob/master/DQM/GEM/plugins/GEMDAQStatusSource.cc#L560]:50: runtime error: shift exponent 39 is too large for 32-bit type 'int'
@smuzaffar
Copy link
Contributor Author

assign dqm

@cmsbuild
Copy link
Contributor

New categories assigned: dqm

@antoniovagnerini,@nothingface0,@rvenditti,@syuvivida,@tjavaid you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cms-bot internal usage

@cmsbuild
Copy link
Contributor

A new Issue was created by @smuzaffar.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dqm-pending pending-signatures
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smuzaffar @cmsbuild