-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proof SERVICER.agc #636 #698
base: master
Are you sure you want to change the base?
Conversation
Update of pages 857-862 (exclusive) of SERVICER.agc
Continue to Page 865, currently finished page 864.
Pages 865 through 870, although unsure about how to handle the newlines in the comment block on page 869, as well as when there is a "+x" in the righmost column, how should they be indented?
Hey @KouroshSimpkins, I didn't see the questions asked in the commit description at the time.
Consecutive line breaks without a line number should be a maximum of 2 line breaks. https://github.com/chrislgarry/Apollo-11/blob/master/CONTRIBUTING.md#line-breaks In the case of
Those should be |
Updated Parts of SERVICER to reflect the assistance provided with reference to large comment block on page 869 and +n in margins. Will continue to move through this (hopefully at about a page per day, maybe faster.) But have exams atm so will be a little slow. -KS
Hi there @wopian, that's my bad I should've probably asked them as a comment in this PR, obviously I forgot because it was an update after I'd opened the PR. Thanks for clearing up those questions I had though, I did think the empty lines would stack, but wasn't sure. I've implemented the changes to reflect your responses. I'll continue to update this PR as I move through SERVICER.agc, and I'll copy my commit descriptions into comments if it makes things easier?
More updates soon |
If you need a question answered it'd be best to copy it as a comment that mentions me (I'll see it much quicker among my other notifications) otherwise the commit descriptions are fine 👍 Feel free to go at your own pace - it's a lot of pages to go through. I've converted the PR to a draft - I believe you'll be able to toggle your own PR by clicking "Ready for review" at the bottom when you've finished. |
Finished checking Page 874
Finished proofing Page 875
@KouroshSimpkins is this still in draft? |
@chrislgarry unfortunately yes, I'm about 65-70% done though. |
I just want to go back and have a cursory second look at what I've done just to make sure it's not foolish. -KS
Okay I'm now happy with what I've done in this proofing, fixed everything that I could find. Hopefully it all looks good! |
Thank you @KouroshSimpkins. I took December off from Open Source development and will be back reviewing the other PRs I was unable to get through in October/November and yours this month onwards 👍 |
Checked pages 857 to 864 Inclusive, and will be continuing on SERVICER.agc.