[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images, videos, iframes #12

Open
piaci opened this issue Apr 4, 2019 · 1 comment
Open

images, videos, iframes #12

piaci opened this issue Apr 4, 2019 · 1 comment

Comments

@piaci
Copy link
piaci commented Apr 4, 2019

hello!
parsed dom does not seem to include images (nor iframe, hence videos).
article object holds a list of Article.Images but Image class is private to get its properties (unless one is parsing that string into an object).

is there any way to:
a) make Image public?
b) add a new property to Image object to point it's location (dom position, text position...)?
c) create a similar object for iframes?

this link includes many images (not even lazy load ones) but none appears after parsing, meanwhile article.images holds them all:
https://www.slashgear.com/apple-airpods-2-review-price-performance-wireless-charging-04572129/

@edwinRNDR
Copy link

Running into same issue as @piacimosca - Article.Image has package visibility and should have public visibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants