[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage: Allow rename of all remote storage vols if cluster member is offline #13939

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Storage: Allow rename of all remote storage vols if cluster member is offline #13939

wants to merge 1 commit into from

Conversation

roosterfish
Copy link
Contributor

This check was hardcoded to work only with the Ceph RBD storage driver as it was the only remote storage driver before we have added support for Dell PowerFlex.

Fixes #13542
The other part of the issue is already addressed in #13934.

@roosterfish roosterfish mentioned this pull request Aug 16, 2024
Merged
@roosterfish
Copy link
Contributor Author
roosterfish commented Aug 16, 2024 •
edited
Loading

Mh, I am not so sure about this block and fail to reproduce or reach this part of the code using the Ceph RBD driver.

There are various variations using --target and --destination-target but for example if you select an offline cluster member using --target you anyway get the error Error: Missing event connection with target cluster member as LXD cannot connect to it (when using the lxc CLI).

This feature was added in #12386 based on issue #11445. But the latest lxc CLI is still using the create/delete approach when when moving the volume. So I assume in order to reproduce this you would need to use the API directly.

But detached from all of this, if you move a volume using the following command, shouldn't we just perform the rename instead of actually performing a copy? I guess by using the API additions from #11445 that would be the case as it just triggers a rename at the end.

tomponline
tomponline reviewed Aug 19, 2024
View reviewed changes
lxd/storage_volumes.go Outdated Show resolved Hide resolved
@roosterfish
lxd/storage_volumes: Allow rename of all remote storage vols if clust…
10cc4cb 
…er member is offline

This check was hardcoded to work only with the Ceph RBD storage driver as it was the
only remote storage driver before we have added support for Dell PowerFlex.

Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomponline tomponline tomponline left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow volumes to be moved from offline members regardless of the storage driver
2 participants
@roosterfish @tomponline