[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Data Validations in backend controllers #271

Open
erenfn opened this issue Oct 7, 2024 · 12 comments
Open

Refactor Data Validations in backend controllers #271

erenfn opened this issue Oct 7, 2024 · 12 comments
Assignees
Labels
backend Backend task/issue bug Something isn't working good-first-issue refactoring make code better

Comments

@erenfn
Copy link
Collaborator
erenfn commented Oct 7, 2024

Refactor Data Validations in backend controllers. There are some repetitive code there. Using express-validator is an option

@erenfn erenfn added bug Something isn't working backend Backend task/issue good-first-issue refactoring make code better labels Oct 7, 2024
@mr-loop-1
Copy link
Contributor
mr-loop-1 commented Oct 7, 2024

Thanks. I can take this up. Will try to keep up with settings branch depending on sequence of merge. As dicussed #211 (comment) , I also think express-validator would be the most suitable.

@eulerbutcooler
Copy link

Can i take this issue up? recently have applied express validator in a mini project of mine i think i can do it

@erenfn
Copy link
Collaborator Author
erenfn commented Oct 8, 2024

Hi! Thanks for your interest. @mr-loop-1 is currently assigned to the issue, so please reach out to him to see if you can collaborate or if he would like to hand it over. I'm fine with either of you taking it on.

@erenfn
Copy link
Collaborator Author
erenfn commented Oct 10, 2024

@mr-loop-1 ?

@mr-loop-1
Copy link
Contributor

Sure @eulerbutcooler you are good to go. Raise your pr against the develop branch and I will add the necessary.

@eulerbutcooler
Copy link

Sure @eulerbutcooler you are good to go. Raise your pr against the develop branch and I will add the necessary.

Thank you! I'll update soon

@eulerbutcooler
Copy link

Hey I've refactored the code and made separate files for checking the validations for some of the controllers. Should i put them in utilis folder or should i include them in the controller file itself? @erenfn @mr-loop-1

@uparkalau
Copy link
Contributor

Hey I've refactored the code and made separate files for checking the validations for some of the controllers. Should i put them in utilis folder or should i include them in the controller file itself? @erenfn @mr-loop-1

Put it in the utils folder. Create a file like validation.

@eulerbutcooler
Copy link

Sure! Just did it #284

@eulerbutcooler
Copy link

Here #285 @uparkalau

@uparkalau
Copy link
Contributor

Here #285 @uparkalau

Fork a new branch from the develop branch. Create PR into develop.

@eulerbutcooler
Copy link

#287 I think this does it. @uparkalau

@mr-loop-1 mr-loop-1 removed their assignment Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend task/issue bug Something isn't working good-first-issue refactoring make code better
Projects
None yet
Development

No branches or pull requests

4 participants