-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Data Validations in backend controllers #271
Comments
Thanks. I can take this up. Will try to keep up with settings branch depending on sequence of merge. As dicussed #211 (comment) , I also think express-validator would be the most suitable. |
Can i take this issue up? recently have applied express validator in a mini project of mine i think i can do it |
Hi! Thanks for your interest. @mr-loop-1 is currently assigned to the issue, so please reach out to him to see if you can collaborate or if he would like to hand it over. I'm fine with either of you taking it on. |
Sure @eulerbutcooler you are good to go. Raise your pr against the develop branch and I will add the necessary. |
Thank you! I'll update soon |
Hey I've refactored the code and made separate files for checking the validations for some of the controllers. Should i put them in utilis folder or should i include them in the controller file itself? @erenfn @mr-loop-1 |
Put it in the utils folder. Create a file like validation. |
Sure! Just did it #284 |
Here #285 @uparkalau |
Fork a new branch from the develop branch. Create PR into develop. |
#287 I think this does it. @uparkalau |
Refactor Data Validations in backend controllers. There are some repetitive code there. Using express-validator is an option
The text was updated successfully, but these errors were encountered: