[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Bitwarden-selfhosted as non-root container on the read-only filesystem #247

Open
shaman007 opened this issue Apr 10, 2024 · 4 comments
Open

Run Bitwarden-selfhosted as non-root container on the read-only filesystem #247

shaman007 opened this issue Apr 10, 2024 · 4 comments

Comments

@shaman007
Copy link

I am running a Bitwarden instance in Kubernetes and want to harden it, because to it contains vital secrets. However, if I try as a start to set:

    spec:
      securityContext:
        runAsUser: 1000
        runAsGroup: 1000
        fsGroup: 1000

I am getting several errors from the entrypoint.sh:

addgroup: Only root may add a user or group to the system.
adduser: Only root may add a user or group to the system.
cp: cannot create regular file '/app/Identity/identity.pfx': Permission denied
cp: cannot create regular file '/app/Sso/identity.pfx': Permission denied

and

sed: couldn't open temporary file /etc/supervisor.d/sedF4AEIa: Permission denied
sed: couldn't open temporary file /etc/supervisor.d/sedMdBMD6: Permission denied
sed: couldn't open temporary file /etc/supervisor.d/sedQ53QO5: Permission denied
sed: couldn't open temporary file /etc/supervisor.d/sedY6JVZS: Permission denied
sed: couldn't open temporary file /etc/supervisor.d/sedTZbdo9: Permission denied
sed: couldn't open temporary file /etc/supervisor.d/sedaiDeBm: Permission denied
sed: couldn't open temporary file /etc/supervisor.d/sedihWpDk: Permission denied
sed: couldn't open temporary file /etc/supervisor.d/sedBm0zaG: Permission denied
chown: changing ownership of '/app/Web/554.48a8997231bd1194fd5f.js': Operation not permitted
chown: changing ownership of '/app/Web/111.a0a028d157496bf5d1fb.js.map': Operation not permitted
chown: changing ownership of '/app/Web/314.5a6aa5e9fd3a1dbb36ce.js.map': Operation not permitted
chown: changing ownership of '/app/Web/encrypt-worker.c5aeb8504a3eb9845db2.js': Operation not permitted
chown: changing ownership of '/app/Web/scripts/qrious.min.js': Operation not permitted
[ ... and so on ... ]

This happens due to the entrypoint.sh:

  • creates user and group
  • creates certificates
  • enable/disable services
  • massively chowns directories

Useradd, groupadd could be easily moved in the Dockerfile, as well as the permissions/group ownership. Seems like "Enable/Disable services" also should be rather in the Dockerfile. /etc/bitwarden that is altered by the entrypoint.sh should be a persistent volume, since we want to keep instance identity on restarts, it's not a problem.
@shaman007 shaman007 mentioned this issue Apr 10, 2024
Closed
@shaman007
Copy link
Author

I did a trivial PR for this issue.

@Neonwarden
Copy link

Hi there,

This issue has been escalated for further investigation. If you have more information that can help us, please add it below.

Thanks!

@yggdrasil-tynor
Copy link

Much needed feature to get this working on Azure AppService / Container Apps!

@djsmith85 djsmith85 linked a pull request Apr 23, 2024 that will close this issue
Make Docker image immutable on runtime #248
Closed
@sincerelysaucy
Copy link

/etc/supervisor.d is mostly where systemd stores content. Don't try to outsmart systemd: Rather than using "bitwarden.sh" directly, create a systemd for bitwarden and enable the designated service user to start or stop that, with the escalations built into systemd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Docker image immutable on runtime shaman007/self-host
4 participants
@shaman007 @yggdrasil-tynor @Neonwarden @sincerelysaucy