[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable path for prime core #119

Merged
merged 1 commit into from
Mar 15, 2019
Merged

Configurable path for prime core #119

merged 1 commit into from
Mar 15, 2019

Conversation

birkir
Copy link
Owner
@birkir birkir commented Mar 15, 2019 
CORE_URL=http://localhost:4000/cms

Will have UI connect to http://localhost:4000/cms and serve Core at /cms.

CORE_URL=http://localhost:4000/cms
CORE_PATH=other

Will have UI connect to http://localhost:4000/cms but serve Core at /other.

So if you don't configure CORE_PATH it will derive from CORE_URL.

@birkir birkir mentioned this pull request Mar 15, 2019
Closed
@codecov
Copy link
codecov bot commented Mar 15, 2019

Codecov Report

Merging #119 into master will decrease coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
- Coverage   78.56%   78.51%   -0.06%     
==========================================
  Files         103      103              
  Lines        2113     2122       +9     
  Branches      150      151       +1     
==========================================
+ Hits         1660     1666       +6     
- Misses        436      438       +2     
- Partials       17       18       +1
Impacted Files Coverage Δ
packages/prime-core/src/utils/config.ts 63.63% <66.66%> (+2.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 171d934...cb70025. Read the comment docs.

@birkir birkir merged commit 4b41064 into master Mar 15, 2019
@birkir birkir deleted the feature/core-path branch March 15, 2019 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@birkir