[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'responsive-margin' addon needs a version bump on NPM #281

Open
camslice opened this issue Feb 18, 2020 · 1 comment
Open

'responsive-margin' addon needs a version bump on NPM #281

camslice opened this issue Feb 18, 2020 · 1 comment

Comments

@camslice
Copy link

Hi @jxnblk,

Creating an issue here because the 'basscss-addons' repo is archived.

I noticed you merged this PR to fix negative margins for the 'responsive-margin': basscss/addons#33

However there is no version bump on NPM, so the package doesn't update when running npm update.

Is there something I'm doing wrong here to get this update?

Thanks, Cam
@camslice
Copy link
Author

I think the issue here is that version bumps have not been published to NPM. If clone the 'basscss-addons' repo and look at package.json I can see that the latest version is actually 1.1.0, whereas the latest version according to NPM is 1.0.0.

Cloning the 'basscss-addons' repo manually also pulls the latest code for 'responsive-margins' including the 'Fix negative margins' PR I mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@camslice