[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand evaluation of global built-ins in @babel/traverse #15797

Merged
merged 15 commits into from
Sep 25, 2023
Merged

Expand evaluation of global built-ins in @babel/traverse #15797

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
328a88e
add global built-in
lorenzoferre Jul 18, 2023
83e837f
add test for global built-in
lorenzoferre Jul 18, 2023
d3a00c2
Merge branch 'upgrade-built-ins'
lorenzoferre Jul 18, 2023
5868b17
fix lint errors
Jul 20, 2023
3a7024a
remove btoa and atob functions
lorenzoferre Jul 21, 2023
0b61dba
rename of constants and methods
lorenzoferre Jul 26, 2023
9ada20a
retrigger checks
lorenzoferre Jul 26, 2023
d0db3c1
prettier changes file
lorenzoferre Jul 27, 2023
b926cef
add node version check
lorenzoferre Jul 27, 2023
2846af3
add tests for the node version check
lorenzoferre Jul 27, 2023
edc24ca
add a check for the split node version
lorenzoferre Jul 27, 2023
0084a6b
Update packages/babel-traverse/src/path/evaluation.ts
lorenzoferre Aug 1, 2023
ae7c04b
remove unused constant
lorenzoferre Aug 1, 2023
6c22846
update btoa and atob tests
lorenzoferre Aug 1, 2023
27bbd12
Update packages/babel-traverse/test/evaluation.js
lorenzoferre Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 30 additions & 5 deletions packages/babel-traverse/src/path/evaluation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,35 @@ import type * as t from "@babel/types";

// This file contains Babels metainterpreter that can evaluate static code.

const VALID_CALLEES = ["String", "Number", "Math"] as const;
const VALID_OBJECT_CALLEES = ["Number", "String", "Math"] as const;
const VALID_IDENTIFIER_CALLEES = [
"isFinite",
"isNaN",
"parseFloat",
"parseInt",
"decodeURI",
"decodeURIComponent",
"encodeURI",
"encodeURIComponent",
process.env.BABEL_8_BREAKING ? "btoa" : null,
process.env.BABEL_8_BREAKING ? "atob" : null,
] as const;

const INVALID_METHODS = ["random"] as const;

function isValidCallee(val: string): val is (typeof VALID_CALLEES)[number] {
return VALID_CALLEES.includes(
function isValidObjectCallee(
val: string,
): val is (typeof VALID_OBJECT_CALLEES)[number] {
return VALID_OBJECT_CALLEES.includes(
// @ts-expect-error val is a string
val,
);
}

function isValidIdentifierCallee(
val: string,
): val is (typeof VALID_IDENTIFIER_CALLEES)[number] {
return VALID_IDENTIFIER_CALLEES.includes(
// @ts-expect-error val is a string
val,
);
Expand Down Expand Up @@ -402,7 +426,8 @@ function _evaluate(path: NodePath, state: State): any {
if (
callee.isIdentifier() &&
!path.scope.getBinding(callee.node.name) &&
isValidCallee(callee.node.name)
(isValidObjectCallee(callee.node.name) ||
isValidIdentifierCallee(callee.node.name))
) {
func = global[callee.node.name];
}
Expand All @@ -415,7 +440,7 @@ function _evaluate(path: NodePath, state: State): any {
if (
object.isIdentifier() &&
property.isIdentifier() &&
isValidCallee(object.node.name) &&
isValidObjectCallee(object.node.name) &&
!isInvalidMethod(property.node.name)
) {
context = global[object.node.name];
Expand Down
56 changes: 56 additions & 0 deletions packages/babel-traverse/test/evaluation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,62 @@ describe("evaluation", function () {
expect(eval_invalid_call.confident).toBe(false);
});

it("should evaluate global call expressions", function () {
expect(
getPath("isFinite(1);").get("body.0.expression").evaluate().value,
).toBe(true);

expect(
getPath("isFinite(Infinity);").get("body.0.expression").evaluate().value,
).toBe(false);

expect(
getPath("isNaN(NaN);").get("body.0.expression").evaluate().value,
).toBe(true);

expect(getPath("isNaN(1);").get("body.0.expression").evaluate().value).toBe(
false,
);

expect(
getPath("parseFloat('1.1');").get("body.0.expression").evaluate().value,
).toBe(1.1);

expect(
getPath("parseFloat('1');").get("body.0.expression").evaluate().value,
).toBe(1);

expect(
getPath("encodeURI('x 1');").get("body.0.expression").evaluate().value,
).toBe("x%201");

expect(
getPath("decodeURI('x%201');").get("body.0.expression").evaluate().value,
).toBe("x 1");

expect(
getPath("encodeURIComponent('?x=1');").get("body.0.expression").evaluate()
.value,
).toBe("%3Fx%3D1");

expect(
getPath("decodeURIComponent('%3Fx%3D1');")
.get("body.0.expression")
.evaluate().value,
).toBe("?x=1");

// the two tests below produce an undefined result when the node version is less than 16
lorenzoferre marked this conversation as resolved.
Show resolved Hide resolved
if (process.env.BABEL_8_BREAKING) {
expect(
getPath("btoa('babel');").get("body.0.expression").evaluate().value,
).toBe("YmFiZWw=");

expect(
getPath("atob('YmFiZWw=');").get("body.0.expression").evaluate().value,
).toBe("babel");
}
});

it("should not deopt vars in different scope", function () {
const input =
"var a = 5; function x() { var a = 5; var b = a + 1; } var b = a + 2";
Expand Down