[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new blurhash property #136

Open
b-lam opened this issue May 31, 2021 · 2 comments
Open

Use new blurhash property #136

b-lam opened this issue May 31, 2021 · 2 comments
Labels

Comments

@b-lam
Copy link
Owner
b-lam commented May 31, 2021

Replace current blur implantation with one that uses the new blurhash property

@b-lam b-lam added enhancement good first issue Good for newcomers labels May 31, 2021
@ashishekka97
Copy link

Hi @b-lam

If it seems fit, I would like to work on this.

I just had one doubt. Isn't it already implemented here: BlurHashDecoder. Or there is some new implementation around there?

P.S I checked the official implementation from here.

@b-lam
Copy link
Owner Author
b-lam commented Jul 2, 2021

Hey @ashishekka97, yeah that would be awesome if you could work on this! I just copied the BlurHashDecoder from that repo but never got around to actually using it. In this file there are some imageview extensions that load images into imageviews. Currently the only blur that I'm using is from another library in this function ImageView.loadBlurredImage and I think that it is not very efficient so I don't do it on lists of images. I wanted to try making the thumbnails loaded by this function ImageView.loadPhotoUrlWithThumbnail blurred with the blur hash and see how that affects performance but never got around to doing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants