[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for additional "switchport default phone" commands #4425

Open
1 task done
dgonzalez85 opened this issue Sep 3, 2024 · 3 comments
Open
1 task done

Support for additional "switchport default phone" commands #4425

dgonzalez85 opened this issue Sep 3, 2024 · 3 comments
Labels
type: enhancement New feature or request

Comments

@dgonzalez85
Copy link
dgonzalez85 commented Sep 3, 2024

Enhancement summary

We would like support for the following commands natively in AVD:

(config)#switchport default phone qos trust ?
  cos   Set trust mode to CoS
  dscp  Set trust mode to DSCP
  
(config)#switchport default phone cos ?
  <0-7>  COS range
 
(config)#switchport default phone trunk untagged phone ?
  <cr>
  
(config)#switchport default phone vlan ?
  <1-4094>  Identifier for a Virtual LAN

(config)#switchport default phone access-list bypass ?
  <cr>

These commands are not supported todavia eos_cli_config_gen:
https://avd.arista.com/4.10/roles/eos_cli_config_gen/docs/input-variables.html#switchport-default

Note: we support "switchport default phone trunk untagged" but not "switchport default phone trunk untagged phone".

Some related TOIs:
https://www.arista.com/en/support/toi/eos-4-28-2f/15899-phone-qos-trust-mode
https://www.arista.com/en/support/toi/eos-4-24-2f/14567-802-1x-on-arista-switches

Which component of AVD is impacted

eos_cli_config_gen

Use case example

Set phone defaults globally via AVD natively.

Describe the solution you would like

Support via eos_cli_config_gen for those commands.

Describe alternatives you have considered

Raw cli.

Additional context

No response

Contributing Guide

  • I agree to follow this project's Code of Conduct
@dgonzalez85 dgonzalez85 added the type: enhancement New feature or request label Sep 3, 2024
@pvinci-arista
Copy link
Contributor

In the realm of automation, do we really want to promote the use of these "convenience" type commands? Is it a better practice to fully specify the interface details in a port profile? The schema validation should probably warn about the use of this family of commands.

@dgonzalez85
Copy link
Author

I'd say thats up to the user to specify this as part of the port-profile or globally. In some cases setting this up globally as a default, may benefit users missing to apply the correct port-profile, misconfigurations etc.

@dgonzalez85
Copy link
Author
dgonzalez85 commented Sep 4, 2024

Also please note:

Phone configurations in the dot1x TOI are using these global commands (check dot1x interaction with phone vlan feature).
https://www.arista.com/en/support/toi/eos-4-24-2f/14567-802-1x-on-arista-switches

And some commands are not available at the interface level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants