Refactor(eos_designs): Change default of redistribute_mlag_ibgp_peering_vrfs to false #4499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4499
# Activate the virtual environment
source test-avd-pr-4499/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@red_mlag_default#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,red_mlag_default --force
# Optional: Install AVD examples
cd test-avd-pr-4499
ansible-playbook arista.avd.install_examples |
127da22
to
b3aeb0b
Compare
ef64d81
to
f71818f
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
f71818f
to
b92ade3
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Co-authored-by: Claus Holbech <holbech@arista.com>
Co-authored-by: Claus Holbech <holbech@arista.com>
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
ClausHolbechArista
approved these changes
Oct 1, 2024
|
LGTM |
laxmikantchintakindi
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Change default of redistribute_mlag_ibgp_peering_vrfs to false
Related Issue(s)
Fixes #4461
Component(s) name
arista.avd.eos_designsProposed changes
Changing default of
redistribute_mlag_ibgp_peering_vrfsinnetwork_servicesandvrfsto false.How to test
molecule test
Checklist
Repository Checklist