[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExoPlayer throw exception on loading attached H.265 ts file #303

Closed
1 task
pengbins opened this issue Apr 7, 2023 · 2 comments · Fixed by #313
Closed
1 task

ExoPlayer throw exception on loading attached H.265 ts file #303

pengbins opened this issue Apr 7, 2023 · 2 comments · Fixed by #313
Assignees
@icbaker
Labels
bug

Comments

@pengbins
Copy link
Contributor
pengbins commented Apr 7, 2023

Media3 Version

ExoPlayer 2.18.5

Devices that reproduce the issue

  • pixel4 running on Android 12
  • maybe any other devices

Devices that do not reproduce the issue

No response

Reproducible in the demo app?

Yes

Reproduction steps

  1. play attached h265_playback_failed.ts file in demo

Expected result

The media file should plays successfully.

Actual result

  1. Toast "Playback failed" message on screen
  2. Check logcat:
com.google.android.exoplayer2.demo   E  Unexpected exception loading stream
  java.lang.IllegalStateException
    at com.google.android.exoplayer2.util.Assertions.checkState(Assertions.java:84)
    at com.google.android.exoplayer2.util.ParsableNalUnitBitArray.assertValidOffset(ParsableNalUnitBitArray.java:209)
    at com.google.android.exoplayer2.util.ParsableNalUnitBitArray.skipBit(ParsableNalUnitBitArray.java:65)
    at com.google.android.exoplayer2.util.ParsableNalUnitBitArray.readBit(ParsableNalUnitBitArray.java:125)
    at com.google.android.exoplayer2.util.ParsableNalUnitBitArray.readExpGolombCodeNum(ParsableNalUnitBitArray.java:193)
    at com.google.android.exoplayer2.util.ParsableNalUnitBitArray.readUnsignedExpGolombCodedInt(ParsableNalUnitBitArray.java:178)
    at com.google.android.exoplayer2.extractor.ts.H265Reader.skipShortTermRefPicSets(H265Reader.java:450)
    at com.google.android.exoplayer2.extractor.ts.H265Reader.parseMediaFormat(H265Reader.java:327)
    at com.google.android.exoplayer2.extractor.ts.H265Reader.endNalUnit(H265Reader.java:214)
    at com.google.android.exoplayer2.extractor.ts.H265Reader.consume(H265Reader.java:164)
    at com.google.android.exoplayer2.extractor.ts.PesReader.consume(PesReader.java:144)
    at com.google.android.exoplayer2.extractor.ts.TsExtractor.read(TsExtractor.java:386)
    at com.google.android.exoplayer2.source.BundledExtractorsAdapter.read(BundledExtractorsAdapter.java:127)
    at com.google.android.exoplayer2.source.ProgressiveMediaPeriod$ExtractingLoadable.load(ProgressiveMediaPeriod.java:1039)
    at com.google.android.exoplayer2.upstream.Loader$LoadTask.run(Loader.java:412)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
    at java.lang.Thread.run(Thread.java:920)

Media

h265_playback_failed.zip

Bug Report
@pengbins pengbins changed the title Exoplayer throw exception on loading Attached H.265 ts file ExoPlayer throw exception on loading Attached H.265 ts file Apr 7, 2023
@pengbins
Copy link
Contributor Author
pengbins commented Apr 7, 2023

The attached TS file can be played by ffplay, potplayer, etc.

@pengbins pengbins mentioned this issue Apr 7, 2023
Closed
@pengbins pengbins changed the title ExoPlayer throw exception on loading Attached H.265 ts file ExoPlayer throw exception on loading attached H.265 ts file Apr 7, 2023
@pengbins pengbins mentioned this issue Apr 11, 2023
Merged
@icbaker icbaker self-assigned this Apr 11, 2023
@icbaker
Copy link
Collaborator
icbaker commented Apr 12, 2023

Thanks for the video, I can reproduce the problem. And thanks for the PR with an explanation of the problem - I'll take a look.

@icbaker icbaker linked a pull request Apr 12, 2023 that will close this issue
Fix skipShortTermRefPicSets in ts/H265Reader #313
Merged
@pengbins pengbins closed this as completed May 2, 2023
@androidx androidx locked and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@icbaker icbaker

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix skipShortTermRefPicSets in ts/H265Reader pengbins/media
2 participants
@icbaker @pengbins