Add the setter counter part of Player.getMaxSeekToPreviousPosition()
#1425
Assignees
Labels
Comments
2 tasks
|
There is no particular not to have such a setter. Do you want to send a PR to add it to |
|
Yes, I can work on a PR for that |
|
I'm closing this, since #1437 has been merged. Feel free to repoen if you prefer to close once it is released. |
|
Closing now is fine. Thanks again for the contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Use case description
Currently, the
Playerinterface provides agetMaxSeekToPreviousPosition()method, which returns a delay after which the player seeks to the previous item, instead of restarting the current item, when callingPlayer.seekToPrevious(). That delay is currently hardcoded toC.DEFAULT_MAX_SEEK_TO_PREVIOUS_POSITION_MS(3 seconds).There is also a
Player.Listener.onMaxSeekToPreviousPositionChanged(long)method, which is called when the delay changes. However, as far as we could see, there is currently noPlayer.setMaxSeekToPreviousPosition(long)method, allowing us to customise that delay.Proposed solution
Provide a
Player.setMaxSeekToPreviousPosition(long)method se the delay can be freely customised by developers.If this request seems reasonable to you, I'm open to work on a PR to help integrate it in Media3.
Alternatives considered
Keep working with the current default delay.
The text was updated successfully, but these errors were encountered: