-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No more env: browser? #1002
Comments
Which package - |
It looks like v3 of That seems like a reasonable thing to reintroduce to the base config, which would eventually make its way back to the main config. However, it's also true that all top-level apps should be defining their own "env" values anyways, so perhaps its best to keep them unspecified? |
So I'm updating from v9.0.1 to v10.0.0 on the main config. I can understand why this disappeared from the base configuration (often used for Node application), but React runs in the browser in the end, so maybe it would be a good thing to reintroduce it in the main config only? Also, why a top level app should define their own |
Our React runs in both the browser and node, and our app sets both envs to true in its top-level config. The top-level app is the only thing that truly knows its own environment - node, browser, tests, amd, etc. I'm not opposed to adding it back, but the more I think about it, the more I think it's not a shareable config's job to set them. |
Agreed. Thanks :) |
Did something change recently in the
env
configuration?I just updated to the latest version in one project and I'm getting a lot of
error 'document' is not defined no-undef
.This is resolved when I manually set the "browser" env in my config but I wonder why it's not done automatically here instead, like it used to be.
The text was updated successfully, but these errors were encountered: