[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add service package #480

Draft
wants to merge 6 commits into
base: development
Choose a base branch
from
Draft

Add service package #480

wants to merge 6 commits into from

Conversation

moorereason
Copy link
Collaborator

To help facilitate new features, begin moving the main webhook service
properties to a Service struct.

@moorereason
Copy link
Collaborator Author

@adnanh,
This PR is a preview of something I've been slowly whittling on. It all started by wanting to fix #393. I needed to be able to access the http.Server from the signal handlers.

This PR doesn't fix #393, but it does lay the groundwork to make that rather easy (see the KPR in the security package). However, there's a lot of changes here which may mean that I need to split this up into smaller steps so that it's easier to review, but I wanted to let you see where I'm headed.

It looks like adding the TLS Curves is a problem in Go 1.14 since the CurveID type didn't support the Stringer interface until Go 1.15. Instead of trying to work around that will build tags, I'll probably wait until Go 1.16 ships, and we can drop Go 1.14. 😃

No rush, but comments are welcome.

@moorereason moorereason force-pushed the service-object branch 3 times, most recently from 295ee6b to cf71b01 Compare December 28, 2020 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moorereason @Maximization @adnanh