feature: combobox field #3381
feature: combobox field #3381
Conversation
|
Code Climate has analyzed commit 627f4af and detected 0 issues on this pull request. View more on Code Climate. |
| @@ -1,3 +1,6 @@ | |||
| require 'net/http' | |||
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
[Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| @@ -1,3 +1,6 @@ | |||
| require 'net/http' | |||
| require 'json' | |||
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
[Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
Still waiting for a response on this thread in regards to supporting objects as values. |
| class Avo::Fields::ComboboxField::EditComponent < Avo::Fields::EditComponent | ||
| def name_when_new | ||
| if @field.accept_free_text | ||
| "#{@resource.form_scope}[#{@field.for_attribute}]" |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
[Corrected] Layout/IndentationWidth: Use 2 (not 1) spaces for indentation.
|
This field needs to be another gem. |
Description
Important
This needs to be another gem.
Fixes #3317
Related to #2711
Other PRs: #2646 & #2718
Checklist:
Screenshots & recording
Manual review steps
Manual reviewer: please leave a comment with output from the test if that's the case.