New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:add some tests for batches #128

Draft

GrapeBaBa wants to merge 1 commit into a16z:master from GrapeBaBa:issue_93

Contributor

GrapeBaBa commented

•

fix #93


          feat:add some tests for batches

666b1db

Signed-off-by: grapebaba <281165273@qq.com>

ncitron reviewed

View reviewed changes

src/derive/stages/batches.rs

+                          Arc::new(RwLock::new(state)),
+                          Arc::new(config.clone()),
+                      );
+                      assert!(batches.next().is_none());

Contributor

ncitron

Shouldn't we be constructing this test to try and get a batch from this?

Contributor Author

GrapeBaBa

@ncitron yeah, just draft, will change this assertion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet