[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reminder outbox next date calculation wrong for peridoic reminders #7382

Open
3 tasks done
Trellmor opened this issue Sep 5, 2024 · 0 comments
Open
3 tasks done

Reminder outbox next date calculation wrong for peridoic reminders #7382

Trellmor opened this issue Sep 5, 2024 · 0 comments
Labels

Comments

@Trellmor
Copy link
Trellmor commented Sep 5, 2024

⚠️ This issue respects the following points: ⚠️

  • This is a bug, not a question or a configuration/webserver/proxy issue.
  • This issue is not already reported on Github (I've searched it).
  • I agree to follow Monica's Code of Conduct.

Bug description

reminder_outbox planned_date is in the past

Steps to reproduce

  1. Running in docker, not sure if important
  2. Account settings, Timezone is UTC+2 Europe/Vienna
  3. Account settings, Time of the day reminders will be sent is 12 AM (must be less then the Timezone Offest from UTC)
  4. Have a Contact with a birthday reminder. planned_date will be e.g. '2024-09-05'
  5. Reminder gets triggered and the E-Mail sent on UTC 2024-09-04 22:00 (= midnight in UTC+2)
  6. The next planned date is calculated, but instead of getting a year from now, it will be still '2024-09-05'

For some reason the calculation in

public function calculateNextExpectedDate($date = null)
returns the current date instead of next years date, if the accounts timezone offset is positive and the trigger time is less than the timezone offset.

Expected behavior

Should creacte a reminder on 2025-09-05

Environment

app.monicahq.com (monica v4)

Version of Monica

4.1.2

Installation method

Docker image

Web server

Apache

Database engine version

MySQL

Additional info

If Time of the day reminders will be sent is larger than the timezone offset, e.g. if it's 3 AM, then the next planned_date is calculated correctly.

@Trellmor Trellmor added the bug label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant