[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable task lists in GFM #48

Open
oschihin opened this issue Jul 25, 2019 · 3 comments · May be fixed by #49
Open

Enable task lists in GFM #48

oschihin opened this issue Jul 25, 2019 · 3 comments · May be fixed by #49
Labels
dormant This issue is dormant. upstream issue Issue of depending external products

Comments

@oschihin
Copy link

This is a feature request.

Specification

According to the plugin specs, this (wonderful, great, irreplacable) plugin supports three MD-flavors, with it, Github Flavored Markdown. I have configured it accordingly: Markdown flavor: github flavored.

One very useful extension from GFM are task lists [1], but they do not seem to work in this plugin. I write:

<markdown>
Shopping List

- [ ] Salt
- [x] Pepper
- [ ] Vinegar
- [ ] Vine

</markdown>

List items display like

<div class="li">[ ] Salt</div>

and not with <input type="checkbox">

Motivations

The motivation is

  1. Accordance with the standard (GMF)
  2. Dokuwiki can be used for checklists / task lists, very handy in a lot of process cases

[1] (https://github.github.com/gfm/#task-list-items-extension-)
@mizunashi-mana mizunashi-mana added the upstream issue Issue of depending external products label Jul 25, 2019
@mizunashi-mana
Copy link
Owner

This plugin uses https://github.com/cebe/markdown, and the spec is followed it.
Now, the library doesn't provide some support for task lists: cebe/markdown#29 .

I marked this issue as an upstream issue.
If the library will support task list, this plugin will support it.

Now, I recommend to use https://www.dokuwiki.org/plugin:todo outside markdown block.

@doekenorg
Copy link
doekenorg commented Oct 15, 2019 •
edited
Loading

FYI: We also needed this, so we built a trait for it you can easily use.

https://github.com/kirra/markdown-task-lists.

@mizunashi-mana mizunashi-mana linked a pull request Oct 15, 2019 that will close this issue
Open
2 tasks
@mizunashi-mana
Copy link
Owner

I push a branch supporting tasklist using kirra/markdown-task-lists . However, this library supports only PHP >= 7.1 though DokuWiki is used on older PHP.

This plugin support older PHP users, so I decide not to merge tasklist support now.

@mizunashi-mana mizunashi-mana added the dormant This issue is dormant. label Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dormant This issue is dormant. upstream issue Issue of depending external products
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tasklist support mizunashi-mana/dokuwiki-plugin-mdpage
3 participants
@doekenorg @oschihin @mizunashi-mana