-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Star this repo on Github
button
#454
Comments
So for this, should we have the button directly star the repository (using the github api) or should we redirect the user to the repository page (using something like this) ? |
@sidtohan the latter. |
Are you interested in taking this up? |
Yes I would be interested in working on this :) |
Hey so is there any update on this issue? If it is still in consideration I would like to work on this. |
Hey apologies I missed the notification. |
Because this will be a visual change, please share your approach/idea for changes before implementing anything. |
That's a good catch. Do we need this or something different? @jayantbh |
Something different is acceptable, @Ankur1493 and @sidtohan The screenshot shared belongs to the landing page. This issue talks about adding a CTA to the docker app. |
@sidtohan been a while, how's are things looking for this? If you are unable to pick this up, let us know! |
Hello, I am facing an issue with the hardware itself of my laptop. It would not be possible to work on this particular issue, so I would request you to assign this to someone else. :( |
Hey @Kamlesh72 , not the place i would want it to be. How about the top-right section of the page-headers? cc: @jayantbh |
Hey @Kamlesh72 , can you raise a PR, so we can start commenting there. Will be easier for me to pick stuff-up for referencing in my comments! |
Also, I am assigning this issue to you! |
@Kamlesh72 did you manage to raise a PR? You can start with proof-of-concept PR, and then work on it, building and polishing it w.r.t the reviewer-comments. |
@e-for-eshaan Not yet. I got some urgent work so was not able to do it, so sorry. I will make the PR by tonight. |
Why do we need this ?
There is no CTA on our app for the users to nudge them to star our repo on GitHub. So creating a button that helps this is needed.
Further Comments / References
something like this:
The text was updated successfully, but these errors were encountered: