[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Star this repo on Github button #454

Closed
e-for-eshaan opened this issue Jul 1, 2024 · 20 comments · Fixed by #532
Closed

Add a Star this repo on Github button #454

e-for-eshaan opened this issue Jul 1, 2024 · 20 comments · Fixed by #532
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers javascript Pull requests that update Javascript code web-server Issue related to web-server

Comments

@e-for-eshaan
Copy link
Contributor

Why do we need this ?

There is no CTA on our app for the users to nudge them to star our repo on GitHub. So creating a button that helps this is needed.

Further Comments / References

something like this:
image

@e-for-eshaan e-for-eshaan added enhancement New feature or request good first issue Good for newcomers javascript Pull requests that update Javascript code web-server Issue related to web-server labels Jul 1, 2024
@sidtohan
Copy link
Contributor

So for this, should we have the button directly star the repository (using the github api) or should we redirect the user to the repository page (using something like this) ?

@jayantbh
Copy link
Contributor

@sidtohan the latter.
Basically a simple CTA in the sidebar (adhering to the theme of the app), at the bottom of it should be sufficient.

@jayantbh
Copy link
Contributor

Are you interested in taking this up?

@sidtohan
Copy link
Contributor

Are you interested in taking this up?

Yes I would be interested in working on this :)

@sidtohan
Copy link
Contributor

Hey so is there any update on this issue? If it is still in consideration I would like to work on this.

@jayantbh
Copy link
Contributor

Hey apologies I missed the notification.
Sure, feel free to take this up, @sidtohan!

@jayantbh
Copy link
Contributor

Because this will be a visual change, please share your approach/idea for changes before implementing anything.

@Ankur1493
Copy link

image
but we already have this in navbar

@sidtohan
Copy link
Contributor
sidtohan commented Aug 4, 2024

image but we already have this in navbar

That's a good catch. Do we need this or something different? @jayantbh

@jayantbh
Copy link
Contributor
jayantbh commented Aug 4, 2024

Something different is acceptable, @Ankur1493 and @sidtohan

The screenshot shared belongs to the landing page. This issue talks about adding a CTA to the docker app.

@e-for-eshaan
Copy link
Contributor Author

@sidtohan been a while, how's are things looking for this?

If you are unable to pick this up, let us know!

@sidtohan
Copy link
Contributor

@sidtohan been a while, how's are things looking for this?

If you are unable to pick this up, let us know!

Hello,

I am facing an issue with the hardware itself of my laptop. It would not be possible to work on this particular issue, so I would request you to assign this to someone else.

:(

@samad-yar-khan
Copy link
Contributor

image but we already have this in navbar

That is on our landing page. We also need a similar functionality within Middleware Opensource.

@Kamlesh72
Copy link
Contributor
Kamlesh72 commented Aug 27, 2024

Suggestions? 🤔

Screenshot 2024-08-27 at 4 37 18 PM

@e-for-eshaan
Copy link
Contributor Author

Hey @Kamlesh72 , not the place i would want it to be. How about the top-right section of the page-headers? cc: @jayantbh

@Kamlesh72
Copy link
Contributor
Kamlesh72 commented Aug 27, 2024

It looks good, but it is very close to loading (can be ignored). If we go with this, should it be shown on every page or just DORA metrics?

Screenshot 2024-08-27 at 7 47 48 PM

Transparent Background 👇🏻
Screenshot 2024-08-27 at 8 11 01 PM

@e-for-eshaan
Copy link
Contributor Author

Hey @Kamlesh72 , can you raise a PR, so we can start commenting there. Will be easier for me to pick stuff-up for referencing in my comments!

@e-for-eshaan
Copy link
Contributor Author

Also, I am assigning this issue to you!

@e-for-eshaan
Copy link
Contributor Author

@Kamlesh72 did you manage to raise a PR? You can start with proof-of-concept PR, and then work on it, building and polishing it w.r.t the reviewer-comments.

@Kamlesh72
Copy link
Contributor

@e-for-eshaan Not yet. I got some urgent work so was not able to do it, so sorry.

I will make the PR by tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers javascript Pull requests that update Javascript code web-server Issue related to web-server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants