[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffrk8s: Remove duplicates entries wip #2580

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

ffrk8s: Remove duplicates entries wip #2580

wants to merge 1 commit into from

Conversation

karampok
Copy link
Contributor
@karampok karampok commented Nov 5, 2024

/kind bug

What this PR does / why we need it:
when we enter

---
apiVersion: metallb.io/v1beta2
kind: BGPPeer
metadata:
  name: bgp-peer1v4
  namespace: metallb-system
spec:
  disableMP: false
  holdTime: 0s
  keepaliveTime: 0s
  myASN: 64500
  password: bgp-test
  passwordSecret: {}
  peerASN: 64500
  peerAddress: 10.46.186.88
  peerPort: 179
---
apiVersion: metallb.io/v1beta1
kind: IPAddressPool
metadata:
  annotations:
    metallb.universe.tf/address-pool: address-pools1
  name: address-pools1
  namespace: metallb-system
spec:
  addresses:
  - |
    4.4.4.100 - 4.4.4.101
  autoAssign: true
  avoidBuggyIPs: false
---
apiVersion: metallb.io/v1beta1
kind: BGPAdvertisement
metadata:
  name: bgpadvertisement
  namespace: metallb-system
spec:
  aggregationLength: 32
  aggregationLengthV6: 128
  communities:
  - 500:500
  ipAddressPools:
  - address-pools1
  localPref: 100
---
apiVersion: metallb.io/v1beta1
kind: BGPAdvertisement
metadata:
  name: bgpadvertisement2
  namespace: metallb-system
spec:
  aggregationLength: 32
  aggregationLengthV6: 128
  communities:
  - 65535:65282
  ipAddressPools:
  - address-pools1
  localPref: 100

the frrconfiguration has duplicates ip prefix entries
Special notes for your reviewer:

Release note:

@karampok
ffrk8s: Remove duplicates entries
ec50d8b 
Signed-off-by: karampok <karampok@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedepaol fedepaol Awaiting requested review from fedepaol fedepaol will be requested when the pull request is marked ready for review fedepaol is a code owner

@russellb russellb Awaiting requested review from russellb russellb will be requested when the pull request is marked ready for review russellb is a code owner

@gclawes gclawes Awaiting requested review from gclawes gclawes will be requested when the pull request is marked ready for review gclawes is a code owner

@oribon oribon Awaiting requested review from oribon oribon will be requested when the pull request is marked ready for review oribon is a code owner

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@karampok