[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LKI of copied spells are not fully implemented #12911

Open
3 tasks
JayDi85 opened this issue Sep 25, 2024 · 0 comments
Open
3 tasks

LKI of copied spells are not fully implemented #12911

JayDi85 opened this issue Sep 25, 2024 · 0 comments
Assignees
Labels
bug Bugs and errors refactoring Developers topics about code and programming

Comments

@JayDi85
Copy link
Member
JayDi85 commented Sep 25, 2024

After Swan Song fix f85a707 from #12883 found many problems:

  1. Looks like original spell LKI implementation is not fully implemented (also related to Unbound Flourishing's PR Unbound Flourishing's X doubling should be a triggered ability (and related refactors) #12597) -- there are many places with stack removing without LKI save, search by getStack().remove. All that places require same fix as Swan Song above.
    shot_240925_095711

  2. All code with spell's copy check is outdated, cause current engine uses really new cards for copies (old code used original card, so that check required). So spell copy check must be removed as outdated. Also manual remove from stack must be removed too -- card moving code already processing it.
    shot_240925_100348
    shot_240925_100959

  3. Many use cases with counter of spell's copy is not covered by tests (no breakpoints at all on debug). So outdate code remove must help with it. If some check code will keep exists then it must be covered by tests like 701bd68.

TODO:

  • remove all calls of getStack().remove from outside of inner game engine
  • make sure counter of copied spells covered by tests (it must counter and save LKI for next effects);
  • review all use of isCopy() and remove outdate code (with spells, with another objects, etc);
@JayDi85 JayDi85 added bug Bugs and errors refactoring Developers topics about code and programming labels Sep 25, 2024
@JayDi85 JayDi85 self-assigned this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs and errors refactoring Developers topics about code and programming
Projects
None yet
Development

No branches or pull requests

1 participant