-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All cards listed in M3C Collector's Edition decks should be Ripple Foil versions #1213
Comments
cc: @taw |
cc: @axxroytovu @kodawah Is this another case where there's more than 2 foiling statuses (nonfoil and foil), like with etched foil before?
It looks like we already use the right card with foil:true and promo:ripplefoil, other than basics. If single mtgjson card has multiple foil subtypes, this is not currently supported, it would need to be split. For etched foils, we marked them in decklists, but it's not currently exported either to the website or to mtgjson data. We could annotate |
This is not an issue with the decks or product definitions. As far as I can tell, the product references are as correct as they can be. TCGPlayer doesn't differentiate between their foil and nonfoil versions in the productID, so there's no way to mark these as specifically the ripple foil version. For products that DO have a different product ID, like the face commanders, I do think they are correctly referenced. |
On tcgplayer the foil version is the ripplefoil, the problem is that scyfall does not distinguish between the two versions, and exports only one single tcgplayer id. In the past this worked because they split such cards in two separate elements, like tcgplayer did, but they are now transitioning towards cards having multiple tcgplayer ids, so that it's possible to map multiple versions without duplicating the whole card entry. Unfortunately some properties (like promo types) only map to the foil printing so the migration is a bit more complicated than just adding a text field. Additionally when this change rolls out, it will affect several past printings, like a few SLD decks. |
Version(s) tested against
MTGJSON 5.2.2+20240718
Description of Bug
Currently all of the cards listed in the following M3C Collector's Edition decks are incorrect and should be the Ripple Foil variant instead.
This appears to be an issue with the M3C (
https://mtgjson.com/api/v5/M3C.json
) set itself.Cards include
ripplefoil
in thepromotypes
property, but the cards themselves do not include the TCGplayer product ID for the Ripple Foil variant.The text was updated successfully, but these errors were encountered: