[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🚀 Feature]: Allow multiple nodes of the same type in Helm configuration #2456

Closed
adriannowak opened this issue Nov 4, 2024 · 2 comments · Fixed by #2475
Closed

[🚀 Feature]: Allow multiple nodes of the same type in Helm configuration #2456

adriannowak opened this issue Nov 4, 2024 · 2 comments · Fixed by #2475
Labels
enhancement
Milestone
4.27.0

Comments

@adriannowak
Copy link

Feature and motivation

Currently, we define browser nodes in the Helm configuration like this:

        chromeNode:
          replicas: 3
          nodeMaxSessions: 3
        firefoxNode:
          enabled: false
        edgeNode:
          enabled: false

This setup is limited, as it doesn’t allow us to configure multiple versions of the same browser.
To increase flexibility, I propose extending the configuration by using arrays:

        chromeNodes:
         - replicas: 3
           extraEnvironmentVariables:
            - name: SE_NODE_STEREOTYPE
              value: '{"browserName":"chrome","platformName":"linux","app":"app1"}'
         - replicas: 3
           extraEnvironmentVariables:
            - name: SE_NODE_STEREOTYPE
              value: '{"browserName":"chrome","platformName":"linux","app":"app2"}'

With this pattern we can configure dedicated pool for apps, override configurations etc.

Usage example

To test the UI of the same feature across different browser versions
@github-actions GitHub Actions
Copy link
github-actions bot commented Nov 4, 2024

@adriannowak, thank you for creating this issue. We will troubleshoot it as soon as we can.

Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@VietND96
Copy link
Member
VietND96 commented Nov 4, 2024

It looks like a complex template to be created. However, it is possible

@VietND96 VietND96 added this to the 4.27.0 milestone Nov 5, 2024
@VietND96 VietND96 linked a pull request Nov 26, 2024 that will close this issue
K8s: Multiple nodes browser in Helm configs #2475
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.27.0
Development

Successfully merging a pull request may close this issue.

K8s: Multiple nodes browser in Helm configs SeleniumHQ/docker-selenium
2 participants
@adriannowak @VietND96