-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial draft for helm chart #21852
Initial draft for helm chart #21852
Conversation
Can we address it in this PR? |
No problem, I was thinking you may want to split the PR into more smaller chunks, I will update the PR with the docs and the CI |
Add helm chart docummentation Add configuration.yaml values
5c840f5
to
1301d50
Compare
@Koenkk I can't add you to reviewers, from my perspective is ready for review. |
set right defaults on values.yaml
… into initial_helm_chart
- name: zigbee2mqtt | ||
image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}" | ||
securityContext: | ||
privileged: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jlpedrosa have you investigated smarter-device-manager
by any chance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, no clue.
Thanks for all your updates, added 2 more comments, after those are solved this can be merged 🥳 Note to self; after this merge Koenkk/zigbee2mqtt.io#2738 |
… into initial_helm_chart
Many thanks for all the effort that went into this! 😄 |
- name: zigbee2mqtt | ||
image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}" | ||
securityContext: | ||
privileged: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize I'm too late, but I'd suggest making this configurable in the future.
I've been using Z2M on kubernetes for a while and it works fine without being privileged using an ethernet coordinator, so some users could do without this
This PR follows up on #21823, it contains the main skeleton to open the conversation. If merged the following items (at least needs to be addressed):
This chart uses a config map to store the configuration, and extracts groups and devices to external files, so it can be managed by the UI. The downside of this approach is that all the other setting are not writable through the UI and needs to be managed through the helm chart.
I've tested this helm chart with: