[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial draft for helm chart #21852

Merged
merged 25 commits into from
May 6, 2024
Merged

Initial draft for helm chart #21852

merged 25 commits into from
May 6, 2024

Conversation

jlpedrosa
Copy link
Contributor
@jlpedrosa jlpedrosa commented Mar 18, 2024

This PR follows up on #21823, it contains the main skeleton to open the conversation. If merged the following items (at least needs to be addressed):

  • Documentation is created in the doc repo in this PR.

This chart uses a config map to store the configuration, and extracts groups and devices to external files, so it can be managed by the UI. The downside of this approach is that all the other setting are not writable through the UI and needs to be managed through the helm chart.

I've tested this helm chart with:

  • no storage (emptyDir)
  • dynamically provisioned volumes
  • statically provisioned volumes.

@Koenkk
Copy link
Owner
Koenkk commented Mar 18, 2024

If merged the following items (at least needs to be addressed):

Can we address it in this PR?

@jlpedrosa
Copy link
Contributor Author

If merged the following items (at least needs to be addressed):

Can we address it in this PR?

No problem, I was thinking you may want to split the PR into more smaller chunks, I will update the PR with the docs and the CI

Add helm chart docummentation

Add configuration.yaml values
@jlpedrosa
Copy link
Contributor Author

@Koenkk I can't add you to reviewers, from my perspective is ready for review.

@jlpedrosa jlpedrosa requested a review from Koenkk March 25, 2024 23:22
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@jlpedrosa jlpedrosa changed the base branch from master to dev May 2, 2024 23:20
- name: zigbee2mqtt
image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
securityContext:
privileged: true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jlpedrosa have you investigated smarter-device-manager by any chance?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, no clue.

@jlpedrosa jlpedrosa requested a review from Koenkk May 4, 2024 00:11
charts/zigbee2mqtt/README.md Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@jlpedrosa jlpedrosa requested a review from Koenkk May 4, 2024 17:01
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@Koenkk
Copy link
Owner
Koenkk commented May 5, 2024

Thanks for all your updates, added 2 more comments, after those are solved this can be merged 🥳

Note to self; after this merge Koenkk/zigbee2mqtt.io#2738

@jlpedrosa jlpedrosa requested a review from Koenkk May 5, 2024 19:35
@Koenkk Koenkk merged commit b2e8b3e into Koenkk:dev May 6, 2024
8 checks passed
@Koenkk
Copy link
Owner
Koenkk commented May 6, 2024

Many thanks for all the effort that went into this! 😄

- name: zigbee2mqtt
image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
securityContext:
privileged: true
Copy link
@Ulrar Ulrar May 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize I'm too late, but I'd suggest making this configurable in the future.
I've been using Z2M on kubernetes for a while and it works fine without being privileged using an ethernet coordinator, so some users could do without this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants