[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce TS strict type checking #1146

Merged
merged 28 commits into from
Aug 16, 2024
Merged

Enforce TS strict type checking #1146

merged 28 commits into from
Aug 16, 2024

Conversation

Nerivec
Copy link
Collaborator
@Nerivec Nerivec commented Aug 10, 2024 •
edited
Loading

TODO:

Also:

  • Use of undefined instead of null allows to reduce MQTT payload sizes by skipping the property entirely (often multiplied by number of devices, so, should make a decent difference)
  • Fix related types
  • Move small utils into single file
  • Cleanup backup conversion utils
  • Add asyncSet function to SerialPort
  • Ember: use constructor/new to init state for Ezsp/Ash layers and use disconnected event to restart Z2M when adapter needs resetting instead of handling internally (aligns behavior with other stacks, ensures clean slate).

@Nerivec
Copy link
Collaborator Author
Nerivec commented Aug 10, 2024

Note to self: all tests are passing locally in c9933a8 (ci fails because of build)

@Nerivec
Copy link
Collaborator Author
Nerivec commented Aug 11, 2024

Tests are passing as of 7fe3e4e and most adapters should now be nearly covered.

@Koenkk if you can take a look at the TODO and XXX I left throughout, and the remaining items in adapter/ezsp, adapter/deconz. I also only did the basics for adapter/z-stack, you will go much faster than me on payloads & co 😜

PS: Only glanced at it, but you can probable remove utils/channels-list and use the ZSpec utils instead, same for constants/zdo.

@Nerivec Nerivec mentioned this pull request Aug 12, 2024
Closed
@Nerivec Nerivec mentioned this pull request Aug 13, 2024
Merged
@Nerivec Nerivec marked this pull request as ready for review August 15, 2024 15:52
@Koenkk Koenkk merged commit 98e3384 into Koenkk:master Aug 16, 2024
1 check passed
@Koenkk Koenkk mentioned this pull request Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Koenkk Koenkk Koenkk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nerivec @Koenkk