[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll out MLJ-compliant document strings for registered models #913

Open
15 of 23 tasks
ablaom opened this issue Mar 8, 2022 · 3 comments
Open
15 of 23 tasks

Roll out MLJ-compliant document strings for registered models #913

ablaom opened this issue Mar 8, 2022 · 3 comments
Labels

Comments

@ablaom
Copy link
Member
ablaom commented Mar 8, 2022

After some preparation and discussion, I am announcing a new standard for MLJ model doc-strings, documented here. I believe detailed doc-strings can greatly improve the on-ramp for new MLJ users, but rolling them out across the MLJ ecosystem is a huge task. Please help if you can.

Here's the list:

Assign yourself by adding your GH handle next the relevant package, or ping me below.

@jbrea @sjvollmer I understand you are using MLJ for teaching these days. Feel free to star (*) or otherwise indicate two or three priority packages (or better still, contribute a PR 😜 )

Procedure

Generally, the procedure for updating the document strings for a package looks like this:

  • Bump the MLJModelInterface [compat] entry to "1.4", to make doc_header and the new human_name trait available, unless you have no plans to reference either.
  • If model metadata (traits) is generated using metadata_model, then remove any descr or docstring kwargs (these two are synonyms) in the metadata_model call. If instead (and atypically) there is an explicit docstring trait declaration (as in MLJModelInterface.docstring(::Type{<:FunkyModel}) = "A funky model") then delete it.
  • Move any existing doc-string for the type to the end of the file that defines the type, following it immediately with a restatement of the type name:
<used to be a doc-string here>
mutable struct FunkyType
    a::Int
end 

<lots of stuff, including metadata declarations>

# # DOCUMENT STRINGS 

"""
    FunkyModel(a=5)

Some stuff about FunkyModel

"""
FunkyModel
  • Assimilate the content of the moved doc-string into a new compliant doc-string, with the help of an existing complaint doc-string you use as a template (classifiers and regressors, transformers).

  • Check the docstring. If the programatically generated header reads strangely, add a human_name declaration (eg, in the metadata_model call).

@logankilpatrick
Copy link
Contributor

@ablaom can you send me a link to where I can see all of the model documentation in its current form?

@ablaom
Copy link
Member Author
ablaom commented Mar 24, 2022

Model-specific documentation is not currently collated. Part of the GSoD project is to create and organise such a collation. So I'd have to write a script that loads every model in the registry (about 200 models) and calls @doc on those types. But with the exception of those packages with ✔️ s above they're mostly empty or quite minimal. Do you want me to write this script? Perhaps you could say would exactly you want this for?

Regarding other documentation. We have a manual and this summary of other learning resources.

@logankilpatrick
Copy link
Contributor

Great, the propsoal has been submitted and is available here: https://julialang.org/jsoc/gsod/2022/proposal/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants