[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modpack_maker_list.txt contains duplicate Download URLs for different mods #267

Open
Noscka opened this issue Jun 17, 2024 · 3 comments
Open

Comments

@Noscka
Copy link
Noscka commented Jun 17, 2024

modpack_maker_list.txt uses the same Download URLs for Different mods. For example Agressor Reshade uses the link: https://www.moddb.com/addons/start/213337 which is correct. but then the same link gets used for Bounty Squads Extended, Lsz AI tweak, Gotta Go Fast, Bizon Replacer and more.

Is this intentional?

@JetPirate
Copy link

Same question. Looking at the history of the file, it's being quite used. Moreover, I've run a script to gather similar questionable items and it seems there are more places like that. First is the number from /start/..., the second is the number of occurrences:

222467 => 10
217186 => 7
213337 => 7
224285 => 6
200140 => 4
242234 => 3
209945 => 3
255058 => 2
243177 => 2
244792 => 2
240548 => 2
231245 => 2
219570 => 2
219923 => 2
202886 => 2
214124 => 2
211552 => 2
218608 => 2
225738 => 2
225029 => 2
210939 => 2
214696 => 2
213259 => 2
210152 => 2
208351 => 2
207498 => 2
208861 => 2

@Noscka
Copy link
Author
Noscka commented Jun 22, 2024

I've looked over how everything works. And there are duplicate mods or different mods which use the same file. But after looking at the commit history, it looks like some of those download IDs get used as a placeholder, I'm guessing. So might explain some of the duplicates. Some might be accidental tho, I have a feeling that the file is manually managed

@Grokitach
Copy link
Owner

Yes this is intentional: patching shit mods / broken mods / with unharmful and small addons to preserve the addons numbering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants