[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] - add options in module properties to change between the default "linear pitch (uniform pitch bends)" or "linear period / frequency (register pitch bends)' #351

Open
djmaximum17 opened this issue Apr 5, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@djmaximum17
Copy link

this would be nice to have in BambooTracker, because I plan to do some covers of PT3 modules some day, since Vortex Tracker II uses linear period / frequency register pitch bends. if it seems a bit too confusing, a video might help showing this off in J0CC FamiTracker.

linear.pitch.and.linear.period.modes.mov
@djmaximum17 djmaximum17 added the enhancement New feature or request label Apr 5, 2021
@rerrahkr
Copy link
Member
rerrahkr commented Apr 9, 2021

Thanks for your request. I recognize the usefulness of this feature, but it is difficult to implement it for now.

In BT, "pitch" is internally defined as 32 division of the seminote. Some effects, such as note sliding, require only simple pitch calculation since the "pitch" distance between adjacent seminotes is fixed.
In register-based pitch processing, the register pitch distance between adjacent seminotes is different for each pitch. Therefore, it is necessary to calculate the value that should be added to the register value at the time of execution of the effect, each time using a conversion formula to frequency.

Unfortunately, I did not consider switching between the two options in the early stages of development, so many parts of BT is implemented the pitch controller assuming the former. It is not easy to change the implementation because there are many parts to need the modification.
However, since the latter option is compatible with traditional MML, I would like to work on it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants