Wikipedia:Bots/Requests for approval/Tom.Bot 3

The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was  Approved.

Operator: Tom.Reding (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)

Time filed: 20:50, Wednesday, February 28, 2018 (UTC)

Automatic, Supervised, or Manual: automatic

Programming language(s): C# & AWB

Source code available: User:Tom.Bot/Task3 code

Function overview: Add {{Taxonbar|from=Q#}} to pages with taxonomic infoboxes

Links to relevant discussions (where appropriate): WT:TREE#Taxonbar addition requirements, Template talk:Taxonbar#Specifying the from/from1 parameter, Taxonbar/doc

Edit period(s): One-time bulk run, with smaller followup runs as needed

Estimated number of pages affected: ~190,000 50,000~100,000 based on preliminary stats

Exclusion compliant (Yes/No): Yes

Already has a bot flag (Yes/No): Yes

Function details: Add {{Taxonbar|from=Q#}}, where Q# is the Wikidata item, to pages that:

1. transclude either {{Automatic taxobox}}, {{Taxobox}}, {{Speciesbox}}, {{Subspeciesbox}}, or {{Infraspeciesbox}}, and
2. contain at least 1 taxonomic ID listed here or here, but excluding TPL, EOL, & GBIF taxonomic IDs from the count, per WT:TREE#Taxonbar addition requirements, and
3. don't already contain a {{Taxonbar}}.

Cosmetic changes piggybacked IIF {{Taxonbar}} is added:

1. {{Reflist}}, {{Commons}}, {{Wikispecies}}, {{FishBase}}, {{Portal}}, {{Portal bar}}, {{Authority control}}, and {{DEFAULTSORT}} are all standardized as shown
2. 1 blank line is added before {{Taxonbar}} when appropriate
3. if DNE, a blank line is added between the end of the infobox & the first line of body-text
4. capitalize |status_system=IUCN<2.3|3.1>
5. remove |image_size= & variants, as the parameter DNE on any affected infobox
6. remove |image_width=<null> & aliases, as |image_upright= is available & preferred on all affected infoboxes
7. {{Italic title}} is moved from !top of the page to the top of the page and standardized as shown
8. Remove {{Clear}}s below cats, as {{Taxonbar}} effectively self-clears via listCell:css('width', '100%') in Module:Navbox
9. WP:GenFixes on

Known issue:

1. When a navbar/navbox is misplaced on the page, i.e. below categories, WP:GenFixes will place it below the {{Taxonbar}}. The correct placement of {{Taxonbar}} is below all navbars (and above {{Authority control}}). These minority instances (~3.5%) will be skipped until the issue is resolved.

 Fixed (diff). If, after GenFixes, any template other than {{DEFAULTSORT}}, {{Authority control}}, {{Clear}}, {{Use DMY dates}}/etc., {{Italic title}}, {{Good article}}, or {{Featured article}} appear after {{Taxonbar}}, then the page is skipped, for manual review. The diff represents the vast majority (~95%) of error cases, so the estimated skip rate will be < 1%, if not ≪ 1%.

Approved for trial (50 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. Don't really see any holdup for this. I'll have some questions, but I need to see the bot in action first. Headbomb {t · c · p · b} 22:10, 9 March 2018 (UTC)[reply]

Trial complete. Edits   ~ Tom.Reding (talk ⋅dgaf)  22:44, 9 March 2018 (UTC)[reply]

Known issue (minor) added to description.   ~ Tom.Reding (talk ⋅dgaf)  16:01, 12 March 2018 (UTC)[reply]

 Fixed.   ~ Tom.Reding (talk ⋅dgaf)  21:47, 12 March 2018 (UTC)[reply]

Approved for extended trial (25 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. to test the updated logic. Headbomb {t · c · p · b} 03:58, 17 March 2018 (UTC)[reply]

Trial complete. Edits. The first (newest) 6 were chosen for removal of {{Clear}}. The next oldest 6 were chosen for moving {{Italic title}} to top. The last (oldest) 13 were chosen for the updated logic (always placing {{Taxonbar}} below even-misplaced navbars).   ~ Tom.Reding (talk ⋅dgaf)  17:52, 17 March 2018 (UTC)[reply]

@Tom.Reding: In edits like [1], italics title should be on its own line. If that's done, I'm fine with approving. However, I feel it would be best to remove both italics title and |name= from the infobox (see Template:Taxobox#Italic page titles), so that the italicization is done automatically via the infobox, e.g. [2]. However, that's my personal opinion, and I'd like the project's feedback on this before mandating this. Headbomb {t · c · p · b} 18:05, 17 March 2018 (UTC)[reply]

Ehhh, I didn't think I'd be getting into the weeds with moving {{Italic title}}. That's a highly conditional effect apparently, and I'd best leave it alone & just let GenFixes do what it wants with it. Will strike from the description.   ~ Tom.Reding (talk ⋅dgaf)  18:20, 17 March 2018 (UTC)[reply]

@Tom.Reding: You could also just add a find \{\{italic title\}\}\{\{ replace {{italic title}}\n{{ and that would take care of that. I'm also entirely fine not messing with the auto-italicization from the infobox as part of this bot run though. Headbomb {t · c · p · b} 18:27, 17 March 2018 (UTC)[reply]

OK,  fixed!   ~ Tom.Reding (talk ⋅dgaf)  18:34, 17 March 2018 (UTC)[reply]

Approved for extended trial (10 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. to check for the italic title thing. Headbomb {t · c · p · b} 19:14, 17 March 2018 (UTC)[reply]

Trial complete. Edits. The first (newest) 5 show {{Italic title}} moves, and the other 5 show in-place corrections. This edit represents a known issue in rdcheck's regex, and has been corrected per the workaround (I decided to re-capture the template #R regexes today to grab any new #Rs that might have shown up since I first started coding this, and accidentally pasta'd over the workaround (?=\s*[\|\}])).   ~ Tom.Reding (talk ⋅dgaf)  20:27, 17 March 2018 (UTC)[reply]

 Approved. Headbomb {t · c · p · b} 20:37, 17 March 2018 (UTC)[reply]

The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.