VisualEditor: [Regression] Link inspector prevents insertion of section links
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Thryduulf
	Aug 22 2013, 4:25 PM

Description

VE link insertion dialog when attempting to add a section link

Since the latest update it is impossible to create links to specific sections of a page in VisualEditor: As soon as you enter the # character the link insertion dialog gives an "Invalid title" error. See screenshot attached and bug 50881 comment 11.

I've reported this separately to bug 50881 as that is an enhancement to give proper handling of section links, but this is a regression that blocks all use of links to sections.

Version: unspecified
Severity: critical

Attached:

Details

Reference: bz53219

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Feature	Esanders	T52881 VisualEditor: Link input widget should suggest section links
		Resolved		Esanders	T55219 VisualEditor: [Regression] Link inspector prevents insertion of section links

Event Timeline

• bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 2:10 AM

• bzimport added projects: VE-deploy-2013-08-29, VisualEditor-EditingTools.

• bzimport set Reference to bz53219.

Thryduulf created this task.Aug 22 2013, 4:25 PM

Ah, good that someone already reported. Confirmed in mediawiki.org.

Change 80417 had a related patch set uploaded by Esanders:
Modify regex to allow section links as valid titles

https://gerrit.wikimedia.org/r/80417

Change 80417 merged by jenkins-bot:
Modify regex to allow section links as valid titles

https://gerrit.wikimedia.org/r/80417

This is now fixed in master; we'll cherry-pick it and push live this afternoon. Sorry for the problem.

Change 80505 had a related patch set uploaded by Jforrester:
Modify regex to allow section links as valid titles

https://gerrit.wikimedia.org/r/80505

Change 80507 had a related patch set uploaded by Jforrester:
Modify regex to allow section links as valid titles

https://gerrit.wikimedia.org/r/80507

Change 80505 merged by Catrope:
Modify regex to allow section links as valid titles

https://gerrit.wikimedia.org/r/80505

Change 80507 merged by Catrope:
Modify regex to allow section links as valid titles

https://gerrit.wikimedia.org/r/80507

… and now deployed.

Unless I'm missing something obvious, I can't make this work anymore on it.wp or Mediawiki. It will just ignore the #name_of_the_section if I add it to an existing wikilink and therefore, it will not recognize the link as edited and the Save button will stay greyed out.

(In reply to comment #10)

Unless I'm missing something obvious, I can't make this work anymore on it.wp
or Mediawiki. It will just ignore the #name_of_the_section if I add it to an
existing wikilink and therefore, it will not recognize the link as edited and
the Save button will stay greyed out.

Split that issue into bug 61221.

Change 112898 had a related patch set uploaded by Esanders:
Include fragments in normalizedTitle

https://gerrit.wikimedia.org/r/112898

Change 112898 merged by jenkins-bot:
Include fragments in normalizedTitle

https://gerrit.wikimedia.org/r/112898

Jdforrester-WMF added a project: VisualEditor.Nov 27 2014, 12:46 AM

• Whatamidoing-WMF mentioned this in T123782: Section links are not being saved.Jan 15 2016, 8:07 PM